Bugfix: Offer decoupled configmap generation in Helm chart #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to deploy the helm chart without having to also directly specify the configmap values all the time in the values section. Also contains a slew of typo fixes and adds the ability to choose feature toggles. Signed-off-by: Jeremy Ho <[email protected]>
kamorel
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows users to deploy the helm chart without having to also directly
specify the configmap values all the time in the values section. Also
contains a slew of typo fixes and adds the ability to choose feature
toggles.
We need to be able to support out-of-band configmap management; this change permits that to happen.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments