Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: FORMS-1706 update vitest #1578

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

build: FORMS-1706 update vitest #1578

wants to merge 3 commits into from

Conversation

WalterMoar
Copy link
Collaborator

Description

Our frontend test suite is out of date and should be updated. The vitest version is 0.32.2, which was released 2023-06-13.

Acceptance Criteria

  • We are running a recent version of vitest, preferably a v2 because v3 is already in beta
  • The tests continue to run as expected

Type of Change

build (change in build system or dependencies)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

This was a little more involved than just updating to the new version:

  • The deps.inline configuration is now deprecated
  • One of the test specs had nested tests. This is not allowed and now produces a warning
  • Tests are failing

@WalterMoar
build: FORMS-1706 update vitest
cbba9dd 
Our vitest is very old and relies on a version of vite that we are not using. We should try to have all our tooling depending on the same vite version.
@WalterMoar
fix: deps.inline is deprecated in this vite/vitest
6c17851
@WalterMoar
fix: nested tests are not allowed
3155167
WalterMoar
WalterMoar commented Jan 15, 2025
View reviewed changes
app/frontend/vite.config.mjs
Comment on lines -67 to +70
deps: {
inline: ['vuetify', 'i18n', 'vitest-canvas-mock'],
server: {
deps: {
inline: ['vuetify', 'i18n', 'vitest-canvas-mock'],
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was warning that deps.inline is a deprecated way of configuring the dependencies.

WalterMoar
WalterMoar commented Jan 15, 2025
View reviewed changes
app/frontend/tests/unit/components/designer/FormViewer.spec.js
it('onMounted', () => {
describe('onMounted', () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested tests are not allowed - but tests within describe are good (as are many levels of nested describes)

abhilash-aot pushed a commit to abhilash-aot/common-hosted-form-service that referenced this pull request Jan 17, 2025
@nimya-aot @jasonchung1871
test: FORMS-1621 Cypress test scripts for display tab for Map compone…
8e9f053 
…nt (bcgov#1552)

* #FORMS-974

* bcgov#974 updates

* bcgov#980 modification to cypress config

* FORMS-980

* bcgov#992

* bcgov#992 Fix cypress scripts

* bcgov#1011 Form design page

* bcgov#1011 test scripts

* bcgov#1023 cypress scripts

* bcgov#1023 advanced data components

* bcgov#1023 Updated scripts

* bcgov#1023 updation

* Updated json file

* Test/forms (bcgov#1011)(bcgov#1023) (bcgov#1307)

* #FORMS-974

* bcgov#974 updates

* bcgov#980 modification to cypress config

* FORMS-980

* bcgov#992

* bcgov#992 Fix cypress scripts

* bcgov#1011 Form design page

* bcgov#1011 test scripts

* bcgov#1023 cypress scripts

* bcgov#1023 advanced data components

* bcgov#1023 Updated scripts

* bcgov#1023 updation

* Updated json file

* bcgov#1059 workflow file for cypress

* bcgov#1059 updated the base url

* bcgov#1059 updated workflow

* Updated node version

* updated

* updated

* Updation

* updated file

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* updated package file

* Update cypress-ci.yaml

* Updated config file

* Update cypress-ci.yaml

* bcgov#1059 updated package

* bcgov#1060 scripts for Advanced fields and BC Gov components

* Fixing review comments

* Updated changes

* # Updated with PR comments

* updated

* Update form-design-basicfields.cy.js

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Modifies test scripts

* Updated files

* Fixed errors during CI/CD Run

* Updated browser type

* Updated Simple BC address component

* Updated

* Fields updated

* Test script changed

* Updated

* Updated fields

* Updated env variable

* Update form-design-basicfields.cy.js

* Updated

* Update cypress-ci.yaml

* Updated email input

* screenshots

* Updated path

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Updated version on workflow

* Fix to failed tests

* Fix to BC address component

* Updated the  component

* Changed button element

* Fixed BC components

* Modified submission

* Modified components

* Updated attribute

* Updated

* Changed simpleBC address component

* Update package.json

* Update package-lock.json

* Test scripts

* Updated

* Pushed the changes

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Env change

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Update cypress-ci.yaml

* Updated

* Updated to take default env variable

* Updated with current workflow

* updated

* Formatted

* Update cypress.config.js

* updated

* Test scripts for updating submission data

* Scripts for adding notes

* Added scripts for logout after each run

* Adding statuses to submission

* Fixed alert message for subscription settings

* Fixing CI/CD running issues

* Fixed issues on schedule date verification

* bcgov#1488 public form submission

* bcgov#1488 form for public

* form settings page for public form

* Added scripts for public forms with no status assign ability

* Changes with login page

* Removed additional login page

* bcgov#1478/Draft submission

* Scripts for draft submission

* bcgov#1478 Added column management functionality and delete button

* Fixed some CI/Cd issues

* bcgov#1478 Renamed public form

* Removed duplicate files

* # Fixed issues after implimenting custom metadata

* Updated settings button

* bcgov#1540 Test scripts for revise status changes

* Modified scripts

* Fixed CI/Cd issue

* bcgov#1547 test scripts for export/imprt design

* bcgov#1547 added preview form

* Added downloads folder to config file

* Added downloads folder

* Fixed spacing issue

* Removed downloaded files

* Modified download folder path

* Fixed some fornmatting issue

* Updated component check

* bcgov#1578 updated scripts

* bcgov#1578 Added email notification

* bcgov#1528 Scripts for email management

* bcgov#1528 Fixed some running issues

* Fixed running issues

* Modified form-team-managememnt.cy.js file name

* Fixed issue with export button click

* bcgov#1346 Test scripts for API export functionality validation

* bcgov#1346 Added External API existence checks

* #1619 Added scripts for validatimg Meta form section

* #1619 Added help link validations on form settings page

* #1621 Test scripts for Map component display tab

* #Added preview button validation along with this script

* #1621 Added validations for custom css class

* Fixed running issues

* Fixed running issues with adding team member on PR env

* Update form-design-map.cy.js

---------

Co-authored-by: jasonchung1871 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WalterMoar