Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1703 Added Tags to port numbers, removed unused port number #1576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

revanth-banala
Copy link
Collaborator

Description

In the devcontainers we now have seven ports, but they are not labeled and it’s not obvious what they’re used for.

It would be better if we labeled these ports so that it was obvious what they were used for. It also appears that the 8081 port isn’t being used.

An example of these labels can be found in portsAttributes settings of this repo:
queue-management/.devcontainer/devcontainer.json at main · bcgov/queue-management

Acceptance Criteria
All of the ports have labels that make it obvious what they are used for.

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant