Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return SMTP response in status #66

Merged
merged 4 commits into from
Jan 26, 2021
Merged

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Jan 22, 2021

Description

Add the smtp response to the Status calls to facilitate troubleshooting.
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-1151

This field is public.message.sendResult in the DB and is populated when the message is set to completed.

Since this is an additive change to a status endpoint I don't think we need to worry about any API versioning on this change.

Leaving draft. If reviews look good will set up some test data before merge on monday.

Add badge (#62) and npm audit fix as well

Types of changes

New feature (non-breaking change which adds functionality)
Documentation (non-breaking change with enhancements to documentation)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the OpenAPI 3.0 v*.api-spec.yaml documentation (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

@loneil loneil requested review from jujaga and TimCsaky January 22, 2021 23:55
@ghost
Copy link

ghost commented Jan 23, 2021

@jujaga jujaga changed the title Return SMPT response in status Return SMTP response in status Jan 25, 2021
@loneil loneil marked this pull request as ready for review January 26, 2021 01:37
Copy link
Contributor

@TimCsaky TimCsaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@TimCsaky TimCsaky merged commit 0527433 into bcgov:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants