-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/script create contacts for existing users/2768 #2844
Open
andrea-williams
wants to merge
9
commits into
develop
Choose a base branch
from
task/script-create-contacts-for-existing-users/2768
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Task/script create contacts for existing users/2768 #2844
andrea-williams
wants to merge
9
commits into
develop
from
task/script-create-contacts-for-existing-users/2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12b592d
to
075670f
Compare
… users, tested against prod
4e03633
to
e9f6abe
Compare
Signed-off-by: SeSo <[email protected]>
Signed-off-by: SeSo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you. 🙏
Not approving this because we don't want to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: #2768
How to Test/Run:
bc_obps/common/management/commands/check_migrations_with_prod_data.py
(regarding making changes to your localbc_obps/.env
file.poetry run python manage.py check_migrations_with_prod_data --pod <pod_name>
, where pod_name is the name of a postgres pod in our Openshift PROD envpoetry run python manage.py migrate registration 0077
andpoetry run python manage.py migrate reporting
to apply all Django migrations except for the migration included in this PRpoetry run python manage.py migrate registration
, which will run the migration included in this PR (registration/0078).For testing purposes, the migration in this PR contains assertions and print statements for testing purposes and to demonstrate that the migration is working as expected. These assertions and print statements will be deleted from the migration before merging (it's also why the pre-commit hook is failing).
REMEMBER TO DELETE YOUR LOCAL COPY OF THE PROD DATA ONCE YOU'VE FINISHED TESTING!