Feat: 343 activity ng transmission non compression #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbastia
force-pushed
the
feat/343-activity-ng-transmission-non-compression
branch
from
bce72e2 to
fbc6ca3
Compare
pbastia
force-pushed
the
feat/343-activity-ng-transmission-non-compression
branch
from
6934d91 to
af900e7
Compare
dleard
approved these changes
Feb 5, 2025
| @@ -0,0 +1,88 @@ | |||
| { | |||
| "type": "object", | |||
| "title": "Flaring stacks", | |||
There was a problem hiding this comment.
We have two very similar source types in our db: "Flaring stacks" & "Flare stacks". I remember asking IRC about this and they said that they are pretty much the same thing, but there is a slight difference (or they are at least named differently in the regs).
Suggested change
| "title": "Flaring stacks", | |
| "title": "Flare stacks", |
| True, | ||
| ), | ||
| ("5_blowdown_venting", "Blowdown venting", False, False), | ||
| ("6_flare_stacks", "Flaring stacks", True, True), |
There was a problem hiding this comment.
Suggested change
| ("6_flare_stacks", "Flaring stacks", True, True), | |
| ("6_flare_stacks", "Flare stacks", True, True), |
| ConfigurationElement.objects.bulk_create( | ||
| ConfigurationElement( | ||
| activity=ng_non_compression_activity, | ||
| source_type=SourceType.objects.get(name="Flaring stacks"), |
There was a problem hiding this comment.
Suggested change
| source_type=SourceType.objects.get(name="Flaring stacks"), | |
| source_type=SourceType.objects.get(name="Flare stacks"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.