Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

464 uat form errors #2728

Merged
merged 8 commits into from
Feb 3, 2025
Merged

464 uat form errors #2728

merged 8 commits into from
Feb 3, 2025

Conversation

gdalcengio
Copy link
Contributor

@gdalcengio gdalcengio commented Jan 23, 2025

464

  • fix: Disable scrolling behavior on global form number inputs
  • chore: Add fuelDescription field to GSC excluding and GSC non-compression forms
  • chore: Add migration to add missing CEMS methodology in reporting GSC activities
  • chore: edit reporting migration just added for rebase
  • feat: Calculate annual fuel amount in Mobile Equipment activity

To Test:

  • Log in with cas dev, head to Bugle SFO - Registered
  • Change activity to Mobile Combustion
  • In mobile activity form, input numbers to q1-4
  • When all 4 have been entered, a sum should appear in annual fuel amount field
  • This field should be read only and should have a default of 0
  • In GSC form, fuel description should be available under fuel
  • In GSC excluding line tracing form, under C02 gastype, methodology should contain CEMS
  • When in report, breadcrumbs should not contain "facilities"
  • On any number field on any form, when selected and cursor is over the field, scrolling should NOT change the form value anymore

@gdalcengio gdalcengio force-pushed the 464-uat-form-errors branch 3 times, most recently from 6207bfb to 0c1a3aa Compare January 29, 2025 17:14
@shon-button
Copy link
Contributor

shon-button commented Jan 30, 2025

Testing Results ALL GOOD ! :)
Fields Reference

feat: Calculate annual fuel amount in Mobile Equipment activity
✅ “Annual Fuel Amount” in Fuel combustion by mobile equipment” activity is calculated
image

chore: Add fuelDescription field to GSC ... forms
Field “Fuel Description” is in step "GSC excluding line tracing activity source types:
✅ "General stationary combustion of fuel or waste with production of useful energy"
image
✅ "General stationary combustion of waste without production of useful energy"
image
final-review
image

chore: Add migration to add missing CEMS methodology in reporting GSC activities
✅ The methodology dropdown for gas type CO2 has option "CEMS”
image

fix: Disable scrolling behavior on global form number inputs

Copy link
Contributor

@shon-button shon-button Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdalcengio

Have we confirmation that the "Fuel Description" is required here (General stationary combustion of fuel or waste with production of useful energy)? I only see reference to section "General stationary combustion of waste without production of useful energy" in the card:

The fuel-related fields do not match the fields in the spreadsheet. Specifically “Fuel Description” is missing in the GSC excluding line tracing activity, under source type "GSC of waste without production of useful energy"

[
# General stationary combustion excluding line tracing
# CO2 - with production of useful energy
ConfigurationElement(
Copy link
Contributor

@shon-button shon-button Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdalcengio

Have we confirmation that the "CEMS" is required here (General stationary combustion of fuel or waste with production of useful energy)? I only see reference to section "General stationary combustion of waste without production of useful energy" in the card:

The methodology dropdown does not match the options in the spreadsheet. Specifically “Methodology 4 (CEMS)” is missing in the 'GSC excluding line tracing' activity, under source type 'GSC of waste without production of useful energy', gas type CO

@gdalcengio gdalcengio merged commit f6685c3 into develop Feb 3, 2025
42 of 51 checks passed
@gdalcengio gdalcengio deleted the 464-uat-form-errors branch February 3, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants