-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: review facilities page #2689
Open
acatchpole
wants to merge
22
commits into
develop
Choose a base branch
from
feat/197-lfo-review-facilities-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayeshmcg
force-pushed
the
feat/197-lfo-review-facilities-page
branch
from
January 17, 2025 01:13
6b67f60
to
e7e895f
Compare
@acatchpole
Remaining:-
|
ayeshmcg
changed the title
feat: review selected facilities page
feat: review facilities page
Jan 17, 2025
ayeshmcg
force-pushed
the
feat/197-lfo-review-facilities-page
branch
from
January 21, 2025 07:32
8ef18d9
to
99b3826
Compare
@acatchpole To do:
|
ayeshmcg
force-pushed
the
feat/197-lfo-review-facilities-page
branch
4 times, most recently
from
January 22, 2025 20:53
aa29c38
to
c948206
Compare
ayeshmcg
force-pushed
the
feat/197-lfo-review-facilities-page
branch
from
January 27, 2025 23:04
9f0b8c7
to
89ffc3b
Compare
acatchpole
force-pushed
the
feat/197-lfo-review-facilities-page
branch
from
January 29, 2025 19:46
dc96de1
to
568d35c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: bcgov/cas-reporting#197
This page is where a user selects what facilities are being reported on. The save function of this page creates a facility report for each facility selected. If unselecting a previously selected facility, that facility report, and any data added to it, will be deleted.
Local Testing
Assumptions:
Steps:
Back
button.Save & Continue
button.Add Facility
button.Submit
button.Sync Latest Data...
button.Save & Continue
buttonContinue
button in the modal- Expect for Facility 1 to no longer be selected
Save
Unresolved issue:
Was unable to find an easy way for the modal to know whether it had been opened by the 'Save' or the 'Save & Continue' button. Currently, if you click 'Continue' from the confirmation modal, you will navigate to the next page, even if you had clicked 'Save' instead of 'Save & Continue'.