Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and optimize all backend API routes - Reg2 #827

Closed
dleard opened this issue Feb 5, 2024 · 6 comments
Closed

Investigate and optimize all backend API routes - Reg2 #827

dleard opened this issue Feb 5, 2024 · 6 comments
Milestone

Comments

@dleard
Copy link
Contributor

dleard commented Feb 5, 2024

Investigate and optimize API endpoints in Reg2. (You can use optimization techniques in the optimization.md file).

Add critical ones below:

  • "/v2/operations/{uuid:operation_id}/registration/operation", (register_edit_operation_information)

Spreadsheet with profiling results:

Endpoint profiling.ods

Not included are:

  • @router.put("/user-operators/{uuid:user_operator_id}", (I couldn't find this being used anywhere)
  • @router.get("/users/{user_id}", (also not used)
  • @router.get("/user-operators/current/is-current-user-approved-admin", (used in the middleware and I was having trouble getting silk to pick it up)
  • any new endpoints created after 2025-02-02

I broke this into three tickets that cover the slowest of the endpoints:

@Dianadec
Copy link
Contributor

Dianadec commented Feb 6, 2024

placeholder card that should probably be split up. cc @dleard

@nanyangpro
Copy link

Re: Refinement discussion - This one is more like an epic. Once we have individual tickets identified, this one will be gone.

@dleard dleard added the Blocked label Mar 11, 2024
@dleard
Copy link
Contributor Author

dleard commented Mar 11, 2024

This can be better defined once #952 and #1061 are complete. Having our API structure split up first will make it easier to write individual cards for each endpoint.

@nanyangpro
Copy link

This will be refined. @andrea-williams

@patriciarussellCAS
Copy link

Flagging that we'll need a similar ticket for Reporting.
cc: @pbastia

@patriciarussellCAS
Copy link

Do in parallel with #2539

@BCerki BCerki self-assigned this Feb 3, 2025
@BCerki BCerki removed their assignment Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants