Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double user lookup (middleware and service functions) #1301

Open
BCerki opened this issue Apr 8, 2024 · 0 comments
Open

Double user lookup (middleware and service functions) #1301

BCerki opened this issue Apr 8, 2024 · 0 comments

Comments

@BCerki
Copy link
Contributor

BCerki commented Apr 8, 2024

Blocked by #827
###Description of the Tech Debt###

For maximum separation between the API and service layer, we pass service functions the user_guid. If we need the full user record, we look it up in the service function. However, we already have the full user record from the middleware when we call the function. This means we look up the user twice, once in the middleware and once in the service function. This ticket is about determining if we should pass the full user record to the service functions to improve performance.

###Tech Debt Triage#
The purpose of our technical debt triage process is to analyze technical debt to determine risk level of the technical debt and the value in tackling that technical debt.

Risk Value Scoring:

Level Value
High 3
Medium 2
Low 1
Technical Debt - Risk Types Level Value
Business Area Risk - Risk of business area visibility / damage to user experience
Developer Fault Risk - How likely will this tech debt cause a future error related to coding on top of it
System Fault Risk - Risk of system errors or application downtime
Time Scale Risk - Compound risk effect if left alone. How much more difficult to fix or dangerous will this become over time?
Time Sink Risk - How much will this tech debt slow the development process down
TOTAL SCORE:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant