chore: cleanup

bcgov · Jan 31, 2025 · 98ed3f3 · 98ed3f3
1 parent 2ea9e6b
commit 98ed3f3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/bc_obps/reporting/api/report_verification.py b/bc_obps/reporting/api/report_verification.py
@@ -1,4 +1,5 @@
 from typing import Literal
+from reporting.models.report_verification import ReportVerification
 from common.permissions import authorize
 from django.http import HttpRequest
 from registration.decorators import handle_http_errors
@@ -20,7 +21,7 @@
 @handle_http_errors()
 def get_report_verification_by_version_id(
     request: HttpRequest, report_version_id: int
-) -> tuple[Literal[200], ReportVerificationOut]:
+) -> tuple[Literal[200], ReportVerification]:
     return 200, ReportVerificationService.get_report_verification_by_version_id(report_version_id)
 
 
@@ -46,6 +47,6 @@ def get_report_needs_verification(request: HttpRequest, report_version_id: int)
 @handle_http_errors()
 def save_report_verification(
     request: HttpRequest, report_version_id: int, payload: ReportVerificationIn
-) -> tuple[Literal[200], ReportVerificationOut]:
+) -> tuple[Literal[200], ReportVerification]:
     report_verification = ReportVerificationService.save_report_verification(report_version_id, payload)
     return 200, report_verification
diff --git a/bc_obps/reporting/schema/report_verification.py b/bc_obps/reporting/schema/report_verification.py
@@ -41,6 +41,8 @@ class ReportVerificationIn(BaseReportVerification):
 
     report_verification_visits: List[ReportVerificationVisitSchema] = Field(default_factory=list)
 
+    class Meta(BaseReportVerification.Meta):
+        fields = BaseReportVerification.Meta.fields
 
 class ReportVerificationOut(BaseReportVerification):
     """

diff --git a/bc_obps/reporting/service/report_verification_service.py b/bc_obps/reporting/service/report_verification_service.py
@@ -7,6 +7,7 @@
 from registration.models import Operation
 from reporting.service.report_additional_data import ReportAdditionalDataService
 from reporting.service.compliance_service import ComplianceService
+from reporting.schema.report_verification import ReportVerificationIn
 
 
 class ReportVerificationService:
@@ -28,7 +29,7 @@ def get_report_verification_by_version_id(
 
     @staticmethod
     @transaction.atomic
-    def save_report_verification(version_id: int, data: ReportVerification) -> ReportVerification:
+    def save_report_verification(version_id: int, data: ReportVerificationIn) -> ReportVerification:
         """
         Save or update a ReportVerification instance.