26211 changed sbc-common-components to version without SBC Connect changes #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed sbc-common-components to version without SBC Connect changes
|
/gcbrun |
|
Temporary Url for review: https://business-edit-dev--pr-616-i6msja1f.web.app SB says, try this: https://business-edit-dev--pr-616-i6msja1f.web.app/BC0887163/alteration |
severinbeauvais
commented
Feb 26, 2025
| @@ -52,7 +52,7 @@ | |||
| "pinia": "^2.0.35", | |||
| "pinia-class": "^0.0.3", | |||
| "regenerator-runtime": "^0.13.11", | |||
| "sbc-common-components": "3.0.17", | |||
| "sbc-common-components": "3.0.15-a", | |||
There was a problem hiding this comment.
As per a conversation with Travis, this is a branch of sbc-common-components that excludes a "SBC Connect" branding commit, which wasn't ready to go to Prod. THIS version can safely go to Prod.
Ref: bcgov/sbc-common-components#384
Yes, I created releases and looked over all the changes and did not see anything that should cause breakages in any UI.
Ref: https://github.com/bcgov/sbc-common-components/releases
JazzarKarim
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#26211
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).