Skip to content

Commit

Permalink
- removed unused ActionTypes from ListPeopleAndRoles.vue (#369)
Browse files Browse the repository at this point in the history
- deleted local ActionTypes enum
- imported shared ActionTypes enum
- removed unused local ActionableItemIF
- imported latest affected shared components
- app version = 3.7.0
  • Loading branch information
severinbeauvais authored Aug 31, 2022
1 parent d69f649 commit 5923920
Show file tree
Hide file tree
Showing 6 changed files with 162 additions and 181 deletions.
292 changes: 146 additions & 146 deletions package-lock.json

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "3.6.0",
"version": "3.7.0",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand All @@ -14,25 +14,25 @@
},
"dependencies": {
"@babel/compat-data": "^7.11.0",
"@bcrs-shared-components/action-chip": "1.0.27",
"@bcrs-shared-components/breadcrumb": "2.0.5",
"@bcrs-shared-components/business-lookup": "1.0.3",
"@bcrs-shared-components/certify": "2.0.8",
"@bcrs-shared-components/completing-party": "2.0.7",
"@bcrs-shared-components/action-chip": "1.0.28",
"@bcrs-shared-components/breadcrumb": "2.0.6",
"@bcrs-shared-components/business-lookup": "1.0.4",
"@bcrs-shared-components/certify": "2.0.9",
"@bcrs-shared-components/completing-party": "2.0.8",
"@bcrs-shared-components/confirm-dialog": "1.1.1",
"@bcrs-shared-components/contact-info": "1.1.9",
"@bcrs-shared-components/contact-info": "1.1.10",
"@bcrs-shared-components/corp-type-module": "1.0.7",
"@bcrs-shared-components/court-order-poa": "2.0.8",
"@bcrs-shared-components/date-picker": "1.1.19",
"@bcrs-shared-components/court-order-poa": "2.0.9",
"@bcrs-shared-components/date-picker": "1.1.20",
"@bcrs-shared-components/detail-comment": "1.0.13",
"@bcrs-shared-components/enums": "1.0.20",
"@bcrs-shared-components/fee-summary": "1.1.22",
"@bcrs-shared-components/enums": "1.0.21",
"@bcrs-shared-components/fee-summary": "1.1.23",
"@bcrs-shared-components/folio-number": "1.0.3",
"@bcrs-shared-components/help-business-number": "1.0.0",
"@bcrs-shared-components/interfaces": "1.0.40",
"@bcrs-shared-components/nature-of-business": "1.0.10",
"@bcrs-shared-components/share-structure": "2.0.1",
"@bcrs-shared-components/staff-payment": "2.0.10",
"@bcrs-shared-components/interfaces": "1.0.41",
"@bcrs-shared-components/nature-of-business": "1.0.11",
"@bcrs-shared-components/share-structure": "2.0.2",
"@bcrs-shared-components/staff-payment": "2.0.11",
"@mdi/font": "^5.5.55",
"@sentry/browser": "^5.23.0",
"@sentry/integrations": "^5.23.0",
Expand Down
2 changes: 0 additions & 2 deletions src/components/common/PeopleAndRoles/ListPeopleAndRoles.vue
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ import OrgPerson from './OrgPerson.vue'
import { CommonMixin, OrgPersonMixin } from '@/mixins/'
import { isSame } from '@/utils/'
import { OrgPersonIF } from '@/interfaces/'
import { ActionTypes } from '@/enums/'
@Component({
components: {
Expand All @@ -291,7 +290,6 @@ import { ActionTypes } from '@/enums/'
export default class ListPeopleAndRoles extends Mixins(CommonMixin, OrgPersonMixin) {
// Declaration for template
readonly isSame = isSame
readonly ActionTypes = ActionTypes
/** Whether to render the OrgPersonForm (for edit or add). */
@Prop() readonly renderOrgPersonForm: boolean
Expand Down
9 changes: 0 additions & 9 deletions src/enums/actionTypes.ts

This file was deleted.

3 changes: 1 addition & 2 deletions src/enums/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export * from './accountTypes'
export * from './actionTypes'
export * from './addressTypes'
export * from './associationTypes'
export * from './businessTypes'
Expand All @@ -22,4 +21,4 @@ export * from './routeNames'

// external enum
export { CorpTypeCd } from '@bcrs-shared-components/corp-type-module/'
export { EntityStates } from '@bcrs-shared-components/enums'
export { ActionTypes, EntityStates } from '@bcrs-shared-components/enums'
7 changes: 0 additions & 7 deletions src/interfaces/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { ActionTypes } from '@/enums/'

export * from './alteration-interfaces'
export * from './correction-interfaces'
export * from './filing-interfaces'
Expand All @@ -10,11 +8,6 @@ export * from './store-interfaces'
export * from './utils-interfaces'
export * from './state-interface'

// this export is needed for some of the shared components
export interface ActionableItemIF {
action: ActionTypes
}

// External interfaces
export {
BusinessLookupIF,
Expand Down

0 comments on commit 5923920

Please sign in to comment.