Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syncing contacts and resources from CKAN #1218

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix syncing contacts and resources from CKAN #1218

merged 1 commit into from
Jan 16, 2025

Conversation

Elson9
Copy link
Contributor

@Elson9 Elson9 commented Jan 16, 2025 •
edited by github-actions bot
Loading

rustyjux
rustyjux approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@rustyjux rustyjux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of hard for me give a meaningful review without more context (how was contacts delivered before vs now, what did you do to test) but seems sound.

@Elson9
Copy link
Contributor Author

Elson9 commented Jan 16, 2025

Kind of hard for me give a meaningful review without more context (how was contacts delivered before vs now, what did you do to test) but seems sound.

Before contacts wasn't converted to a string, and it was the displayed array which was causing the error. I tested locally with Postman, using a PUT request to /feed/Dataset with the JSON that was causing the error

@ikethecoder ikethecoder merged commit 5055584 into dev Jan 16, 2025
8 checks passed
@ikethecoder ikethecoder deleted the feature/fix-ckan-contacts branch January 16, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikethecoder ikethecoder ikethecoder approved these changes

@rustyjux rustyjux rustyjux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syncing contacts and resources from CKAN producing an error
3 participants
@Elson9 @ikethecoder @rustyjux