-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure wrapping code for air zone reports #4
Open
karawoo
wants to merge
54
commits into
bcgov:fig-wrapping
Choose a base branch
from
karawoo:fig-wrapping
base: fig-wrapping
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,774
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One report (Georgia Strait) with 4 plots + helper functions and script to generate report output
Co-Authored-By: karawoo <karawoo@users.noreply.github.com>
There is an issue with how the air zone management level column gets colored (part of the header gets colored as well), need to look into this
Only 24h; need to add columns for annual mean still
Will need to tweak figure appearance for some of them
Requires compiling with lualatex or xelatex
Captions are now functions in the functions.R script
Depends on changes in this branch: bcgov/pm25-caaqs-indicator#8
No real reason to have them separate
No need to make sure there is room for the "CAAQS" label
fig.env = "wrapfigure" is not sufficient, because \begin{wrapfigure} requires some additional options
No longer need to join with stations data frame because the necessary info is now included in the annual data
Thanks @karawoo - this is great to have! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has everything from #3, plus code to attempt wrapping text around figures (currently used in 05_georgia_strait.Rmd only as a test case). It uses the wrapfigure package for LaTex and defines a custom knitr chunk hook that generates LaTeX code for wrapped figures. However it will need further customization based on the actual figure sizes, length of text, etc. to look good -- right now either we have large empty spaces on some pages, or figures that overlap or appear out of order with the text.