PSP-9900 : PIMS service availability notifications #4674
Conversation
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4674 |
| </label> | ||
| {systemChecks.length > 1 && ( | ||
| <LinkButton | ||
| data-testid="healtcheck-full-list" |
There was a problem hiding this comment.
nit: healthcheck-full-list
| totalDuration: Date; | ||
| // Dictionary of health information. | ||
| entries: { | ||
| PmbcExternalApi: { |
There was a problem hiding this comment.
each of these objects:
{
data: object;
duration: Date;
status: string;
tags: string[];
}
appears the same, could these be defined by an interface to reduce repetition?
| return ( | ||
| const [systemChecked, setSystemChecked] = useState<boolean>(null); | ||
| const [systemDegraded, setSystemDegraded] = useState<boolean>(false); | ||
| const [healthCheckIssues, sethealthCheckIssues] = useState<IHealthCheckIssue[]>(null); |
There was a problem hiding this comment.
nit: setHealthCheckIssues.
| return systemDegraded && systemChecked ? ( | ||
| <> | ||
| <LoadingBar style={{ zIndex: 9999, backgroundColor: '#fcba19', height: '.3rem' }} /> | ||
| <Styled.AppGridContainerWithHealth className="App" {...rest}> |
There was a problem hiding this comment.
How would you feel about using a css class to show/hide the health container? it seems like you are having to duplicate lines 109 to 115 because of this approach.
There was a problem hiding this comment.
I am not opposed to the idea, but managing the grid-template-areas without breaking the app layout is complicated enough.
There was a problem hiding this comment.
@eddherrera I tested this out, and this solution isn't viable as it causes the map to be de-rendered and re-rendered. Please change this so that the banner is added and removed as needed without re-rendering the entire application.
|
At the moment, it does not appear that this AC is satisfied: Each of these messages should be alterable via configuration on the frontend. Therefore, we should use keys to refer the services to the messages. |
updated tenant file to store messages. |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4674 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4674 |
| import * as Styled from './styles'; | ||
|
|
||
| const PublicLayout: React.FC<React.PropsWithChildren<React.HTMLAttributes<HTMLElement>>> = ({ | ||
| children, | ||
| ...rest | ||
| }) => { | ||
| return ( | ||
| const [systemChecked, setSystemChecked] = useState<boolean>(null); |
There was a problem hiding this comment.
I don't think this logic should be added to the publicLayout. The PublicLayout should be stateless, and just accept params for these health check items.
| const { setModalContent, setDisplayModal } = useModalContext(); | ||
|
|
||
| return ( | ||
| systemChecks.length && ( |
There was a problem hiding this comment.
this appears to throw an NPE, as this is initialized with null until the promise returns.
|
It looks like errors for keys with spaces aren't displaying properly: |
This should just be displaying as "PMBC". all of the keys should display as per the below: CDOGs (The DevExchange Document Generation Service is experiencing service degradation, you will be unable to generate form documents (ie. H120, H1005) until resolved). MAYAN (The PIMS Document server is experiencing service degradation, you will be unable to view, download or upload documents until resolved) PIMS API (The PIMS server is currently unavailable, PIMS will not be useable until this is resolved). PMBC (The BC Data Warehouse is experiencing service degradation, this will limit PIMS map functionality until resolved). GEOCODER (The BC Geocoder is experiencing service degradation, address search will be unavailable until resolved). GEOSERVER (The MOTT Geoserver is experiencing service degradation, PIMS map layer functionality will be limited until resolved). LTSA (The LTSA title service is experiencing service degradation, the LTSA tab within a property will not be viewable until resolved). |
No description provided.