Psp 9940 - correct issue with map display when jumping to boundaries #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinleighsmith
commented
Feb 11, 2025
| @@ -168,9 +168,7 @@ const mapRequestStates = { | |||
| context?.mapFeatureData?.pimsLocationFeatures?.features ?? []; | |||
|
|
|||
| // business logic, if there are file properties, use those, otherwise, zoom to a single feature if there is only one, or all features if there are more than one. | |||
| if (context.filePropertyLocations.length > 0) { | |||
There was a problem hiding this comment.
unfortunately this logic doesn't work - as this method has no context who called it. As a result, efforts to send a fileProperties of [], result in the else clause of this function to be executed.
suggested solution - keep the file boundary logic separate from the map load/ map search logic.
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4648 |
asanchezr
approved these changes
Feb 11, 2025
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.