Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: commas on geo names and ids #3862

Merged
merged 2 commits into from
Feb 12, 2025
Merged

fix: commas on geo names and ids #3862

merged 2 commits into from
Feb 12, 2025

Conversation

rafasdc
Copy link
Collaborator

@rafasdc rafasdc commented Feb 11, 2025 •
edited by github-actions bot
Loading

Implements NDT-762

  • Check to trigger automatic release process

  • Check for automatic rebasing

@rafasdc rafasdc marked this pull request as ready for review February 11, 2025 21:34
AntBush
AntBush approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@AntBush AntBush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed, but I wonder if extracting this logic into a function would make it more readable

@rafasdc rafasdc force-pushed the NDT-762-GeographicID-in-XlS-download-has-one-row-not-comma-separated branch from 322872d to d1bd89a Compare February 12, 2025 16:53
@rafasdc rafasdc force-pushed the NDT-762-GeographicID-in-XlS-download-has-one-row-not-comma-separated branch from d1bd89a to 7c680f2 Compare February 12, 2025 18:46
@ccbc-service-account @rafasdc
chore: release v1.243.3
9ea087c 
test: update tests
@rafasdc rafasdc force-pushed the NDT-762-GeographicID-in-XlS-download-has-one-row-not-comma-separated branch from c101198 to 9ea087c Compare February 12, 2025 19:58
@ccbc-service-account ccbc-service-account merged commit 2bf58b1 into main Feb 12, 2025
64 checks passed
@ccbc-service-account ccbc-service-account deleted the NDT-762-GeographicID-in-XlS-download-has-one-row-not-comma-separated branch February 12, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntBush AntBush AntBush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafasdc @AntBush @ccbc-service-account