Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest pkg js #218

Merged
merged 3 commits into from
Jan 11, 2024
Merged

latest pkg js #218

merged 3 commits into from
Jan 11, 2024

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jan 11, 2024

  • Enable and fix a number of lints
  • Support latest pkg:js, require Dart v3, update and fix lints

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 11, 2024

@Ephenodrom – you around?

@Ephenodrom
Copy link
Contributor

@kevmoo sorry I have totally forgotten about this pr. Currently the Chrome pipeline seems to have some test failures. If this is fixed I will merge the PR and upload a new version on pub.dev.

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 11, 2024

@Ephenodrom it looks like timeouts. Could you hit the re-run button?

I'll validate locally...

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 11, 2024

@Ephenodrom – chrome passes IF you use -j 1 – so concurrency is causing the problems here.

@Ephenodrom Ephenodrom merged commit c975812 into bcgit:master Jan 11, 2024
2 of 3 checks passed
@kevmoo kevmoo deleted the latest_pkg_js branch January 11, 2024 20:11
@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 11, 2024

@Ephenodrom – you're going to publish, right? Thanks so much!

@Ephenodrom
Copy link
Contributor

@kevmoo Strange bug, the PR is marked as merged, but the changes are not in the master branch. Any idea ?

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 11, 2024

@Ephenodrom – looks like it rolled back? weird!!!

@Ephenodrom
Copy link
Contributor

@dghgit Hello David, we have strange problem. It seems that the merged requests are rolled back. Any idea if this has something to do with the mirror ? I assume that this is NOT a generic github bug ...

@kevmoo FYI

@dghgit
Copy link
Contributor

dghgit commented Jan 12, 2024

@Ephenodrom did you merge into the backing repository? (You need to follow the command line instructions on the backing repo). Once the change is committed and pushed the mirror will pick it up, at the moment the mirror is showing this as the latest:

commit 59e06028bff338adc7d25ff9da4063a3b2e28b4c (HEAD -> master, origin/master, origin/HEAD)
Author: Ephenodrom <[email protected]>
Date:   Fri Apr 14 18:02:01 2023 +0200

    Prepare release 3.7.2

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 12, 2024

This would be a chance to rebase and make a more clean commit, too!

@Ephenodrom
Copy link
Contributor

@kevmoo Ok now i know how to merge it in the base repo. Any chance on reopening the PR or recreating the branch in your fork ?

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 12, 2024

#220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants