-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest pkg js #218
latest pkg js #218
Conversation
kevmoo
commented
Jan 11, 2024
- Enable and fix a number of lints
- Support latest pkg:js, require Dart v3, update and fix lints
@Ephenodrom – you around? |
@kevmoo sorry I have totally forgotten about this pr. Currently the Chrome pipeline seems to have some test failures. If this is fixed I will merge the PR and upload a new version on pub.dev. |
@Ephenodrom it looks like timeouts. Could you hit the re-run button? I'll validate locally... |
@Ephenodrom – chrome passes IF you use |
@Ephenodrom – you're going to publish, right? Thanks so much! |
@kevmoo Strange bug, the PR is marked as merged, but the changes are not in the master branch. Any idea ? |
@Ephenodrom – looks like it rolled back? weird!!! |
@Ephenodrom did you merge into the backing repository? (You need to follow the command line instructions on the backing repo). Once the change is committed and pushed the mirror will pick it up, at the moment the mirror is showing this as the latest:
|
This would be a chance to rebase and make a more clean commit, too! |
@kevmoo Ok now i know how to merge it in the base repo. Any chance on reopening the PR or recreating the branch in your fork ? |