Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generics to generateKeyPair #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/key_generators/ec_key_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class ECKeyGenerator implements KeyGenerator {
}

@override
AsymmetricKeyPair generateKeyPair() {
AsymmetricKeyPair<ECPublicKey, ECPrivateKey> generateKeyPair() {
var n = _params.n;
var nBitLength = n.bitLength;
BigInt? d;
Expand Down
2 changes: 1 addition & 1 deletion lib/key_generators/rsa_key_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class RSAKeyGenerator implements KeyGenerator {
}

@override
AsymmetricKeyPair generateKeyPair() {
AsymmetricKeyPair<RSAPublicKey, RSAPrivateKey> generateKeyPair() {
BigInt p, q, n, e;

// p and q values should have a length of half the strength in bits
Expand Down
4 changes: 2 additions & 2 deletions tutorials/examples/rsa-demo.dart
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ AsymmetricKeyPair<RSAPublicKey, RSAPrivateKey> generateRSAkeyPair(

// Cast the generated key pair into the RSA key types

final myPublic = pair.publicKey as RSAPublicKey;
final myPrivate = pair.privateKey as RSAPrivateKey;
final myPublic = pair.publicKey;
final myPrivate = pair.privateKey;

// The RSA numbers will always satisfy these properties

Expand Down