Fix v4 skesk argon2 test vectors #1744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitasvitae
force-pushed
the
fixV4SKESK_Argon2_testVectors
branch
from
1e51d4d to
dd2aa9c
Compare
vanitasvitae
force-pushed
the
fixV4SKESK_Argon2_testVectors
branch
from
dd2aa9c to
d5a348c
Compare
hubot
pushed a commit
that referenced
this pull request
Sep 13, 2024
hubot
pushed a commit
that referenced
this pull request
Sep 13, 2024
#1744 Fix v4 skesk argon2 test vectors See merge request root/bc-java!23
|
In main as 3c9c1fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Argon2S2KTestcontained a test vector, where the wrong sample data was pasted.This PR replaces the contents of the v4 SKESK with Argon2 + AES256 with the proper test vector (it used to contain the AES192 vector by accident).