Implement OpenPGP v6 & LibrePGP v5 signature verification #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitasvitae
force-pushed
the
verifyV6Sigs
branch
from
7158bc1 to
18152f9
Compare
vanitasvitae
force-pushed
the
verifyV6Sigs
branch
from
95331b4 to
13af45d
Compare
vanitasvitae
changed the title
CANONICAL_TEXT signatures update() would handle 'd0' specially, resulting in broken signature verification if salt contained 'd0'. With this patch, we push salt to sigOut directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements verification of v6 signatures.
It also now fixes parsing and fingerprint calculation (#1703) of v5 keys, as well as initial v5 signature verification.