-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marco-bertschi I had a quick look, without digging into the functionality. Some points raised, see comments.
src/BBT.StructureTools.Tests/Compare/ComparerWithObjectAttributeTests.cs
Show resolved
Hide resolved
src/BBT.StructureTools/Strategy/GenericCreateByBaseAsCriterionStrategy.cs
Outdated
Show resolved
Hide resolved
src/BBT.StructureTools/Copy/Operation/ICopyOperationCrossReferenceProcessing.cs
Outdated
Show resolved
Hide resolved
src/BBT.StructureTools/Copy/Operation/ICopyOperationCrossReferenceProcessing.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more points added.
Also public API is quite huge. Does this stuff really all need to be public (e.g. BBT.StructureTools.Compare.Helper)? Can you please go through the API and make everything internal which doesn't need to be public (you can call .\build.ps1 -target preview-documentation
and check in the documentation the public API).
src/BBT.StructureTools/Strategy/ICreateByBaseAsCriterionStrategy.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more points added.
Also public API is quite huge. Does this stuff really all need to be public (e.g. BBT.StructureTools.Compare.Helper)? Can you please go through the API and make everything internal which doesn't need to be public (you can call
.\build.ps1 -target preview-documentation
and check in the documentation the public API).
I'll do that sunday. I've fixed your other comments already. Can you have an extra look at the nuspec file?
@marco-bertschi let me know if you need a review or @pascalberger will do it? |
@Speeedy01 I only did have a quick look without reviewing the business logic of the code. Happy to have you do another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes and suggestions
...StructureTools.Tests/Compare/ComparerWithObjectAttributeWithDistinguishedComparerIntTests.cs
Show resolved
Hide resolved
src/BBT.StructureTools.Tests/Convert/ConvertRootTreeLeafWithMasterDataTests.cs
Show resolved
Hide resolved
...ools.Tests/Convert/TestStructure/Registration/LeafMasterDattargetLeafConvertRegistrations.cs
Outdated
Show resolved
Hide resolved
src/BBT.StructureTools.Tests/Copy/CopyOperationCreateToManyFromGenericStrategyIntTests.cs
Outdated
Show resolved
Hide resolved
src/BBT.StructureTools.Tests/Copy/CopyOperationCreateToOneWithReverseRelationIntTests.cs
Outdated
Show resolved
Hide resolved
src/BBT.StructureTools.Tests/TestTools/PopPropValueExtensions.cs
Outdated
Show resolved
Hide resolved
af93268
to
1ade447
Compare
Requested changes were addressed
First and initial commit to port our BBT structure tools to GitHub.