Drop auth_info on redirect #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this addresses a case where a user-facing registry redirects to blob storage in S3, providing a URL that includes various `X-Amz-*` query parameters. S3 refuses requests that have both Authentication header and authentication query parameters.
jklukas
requested review from
eed3si9n,
non,
ianoc,
adam-singer and
ramyanaga
non
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this addresses a case where a user-facing registry redirects to blob storage in S3, providing a URL that includes various
X-Amz-*query parameters. S3 refuses requests that have both Authentication header and authentication query parameters.I think this is generally safe to do. If the redirect is to a different path under the same registry, then the request to new location would include another authentication challenge and the same authentication helper rules would be applied, restoring auth. If the redirect is to a different domain, then I wouldn't expect the same authentication to be accepted anyway, so dropping auth info seems generally desirable.