Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to ExtraDependencyInfo Provider #54

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Updates to ExtraDependencyInfo Provider #54

merged 1 commit into from
Jul 19, 2024

Conversation

ramyanaga
Copy link
Contributor

This PR:

  • renames ExtraDependencyProvider -> ExtraDependencyInfo
  • updates the provider definition to include documentation
  • updates the type of config_java_info attribute from list[JavaInfo] -> depset[JavaInfo]

@ramyanaga ramyanaga marked this pull request as draft July 19, 2024 19:03
@ramyanaga ramyanaga force-pushed the ramya/depset-and-rename-0719 branch from 8fc2d84 to 5af17a1 Compare July 19, 2024 19:07
@ramyanaga ramyanaga marked this pull request as ready for review July 19, 2024 19:10
@ramyanaga ramyanaga merged commit 9e860d3 into main Jul 19, 2024
16 checks passed
@ramyanaga ramyanaga deleted the ramya/depset-and-rename-0719 branch July 19, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

@johnynek johnynek johnynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramyanaga @johnynek @eed3si9n