Skip to content

Commit

Permalink
Merge pull request #51 from bazeltools/ramya/bazel_jar_jar_aspect_cha…
Browse files Browse the repository at this point in the history
…nge_0717

Add ConfigJavaInfo to jar jar aspect
  • Loading branch information
eed3si9n authored Jul 18, 2024
2 parents b75e1f4 + bfcb796 commit d935588
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion jar_jar_aspect.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ ShadedJars = provider(fields = [
"transitive_shaded",
])

ConfigJavaInfo = provider(fields = [
"config_java_info"
])

def merge_shaded_jars_info(shaded_jars):
return ShadedJars(
output_files = depset(transitive = [s.output_files for s in shaded_jars]),
Expand Down Expand Up @@ -57,10 +61,15 @@ def _jar_jar_aspect_impl(target, ctx):
return []

current_jars = [j for j in target[JavaInfo].runtime_output_jars]

# For some outputs, like those from the built in java proto aspect, the runtime output jars is empty, but the jars
# exist instead in the java_outputs section.
current_jars.extend([e.class_jar for e in target[JavaInfo].java_outputs])
java_info_runtime_deps = []

if ConfigJavaInfo in target:
java_info_runtime_deps.append(target[ConfigJavaInfo].config_java_info)
#current_jars.extend([e.class_jar for e in target[ConfigJavaInfo].config_java_info.java_outputs])
toolchain_cfg = ctx.toolchains["//toolchains:toolchain_type"]
rules = toolchain_cfg.rules.files.to_list()[0]
duplicate_to_warn = toolchain_cfg.duplicate_class_to_warn
Expand All @@ -73,7 +82,6 @@ def _jar_jar_aspect_impl(target, ctx):
current_jars = [_build_nosrc_jar(ctx)]

transitive_shaded=[]
java_info_runtime_deps = []
if hasattr(ctx.rule.attr, "runtime_deps"):
for d in ctx.rule.attr.runtime_deps:
if ShadedJars in d:
Expand All @@ -91,6 +99,7 @@ def _jar_jar_aspect_impl(target, ctx):
transitive_shaded.append(shaded_jars.transitive_shaded)
java_info_exports.append(shaded_jars.java_info)


java_info_deps = []
for d in ctx.rule.attr.deps:
if ShadedJars in d:
Expand Down

0 comments on commit d935588

Please sign in to comment.