Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support no_std in Prost toolchain #3180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support no_std in Prost toolchain #3180

wants to merge 1 commit into from

Conversation

fionera
Copy link
Contributor

@fionera fionera commented Jan 10, 2025

No description provided.

@fionera fionera force-pushed the prost-no-std branch 4 times, most recently from dfc73de to 4062960 Compare January 10, 2025 21:13
UebelAndre
UebelAndre requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor request!

extensions/prost/private/prost.bzl Outdated Show resolved Hide resolved
UebelAndre
UebelAndre requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit and I think you can delete rust_prost.md since docs are now generated directly from the bzl source file. Devs no longer need to render them and add them to their PRs 😄

extensions/prost/private/protoc_wrapper.rs Outdated Show resolved Hide resolved
UebelAndre
UebelAndre approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre added this pull request to the merge queue Jan 28, 2025
@UebelAndre UebelAndre removed this pull request from the merge queue due to a manual request Jan 28, 2025
UebelAndre
UebelAndre requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, is there some sort of integration test you can add that uses this new flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fionera @UebelAndre @lorenz