-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xctrunner rule to create test bundles #2529
Open
kapoorlakshya
wants to merge
2
commits into
bazelbuild:master
Choose a base branch
from
kapoorlakshya:lk/test_runner_bundle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add xctrunner rule to create test bundles #2529
kapoorlakshya
wants to merge
2
commits into
bazelbuild:master
from
kapoorlakshya:lk/test_runner_bundle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5828884
to
86139ab
Compare
86139ab
to
ddf9e8d
Compare
680bc38
to
3f044b3
Compare
8cd6f3b
to
53d6e3a
Compare
apple/internal/xctrunner.bzl
Outdated
Comment on lines
93
to
137
# Limiting the contents of AppleBinaryInfo to what is necessary | ||
# for testing and validation. | ||
xctrunner_binary_info = new_applebinaryinfo( | ||
binary = output, | ||
infoplist = None, | ||
product_type = None, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like AppleBundleInfo
might be a better fit then, since we are producing a bundle?
53d6e3a
to
019c196
Compare
019c196
to
b65dfbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new rule
xctrunner
which allows bundling of one or morexctest
s into a singleXCTRunner.app
. Primary use case is for running UI tests on real device farms, like BrowserStack, Sauce Labs, etc.Usage