Fix broken builds with Bazel < 6.4.0 #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
approved these changes
Jan 23, 2024
|
interestingly bazel 6.x tests pass without this #2380 i guess because it just doesn't hit this path |
Which doesn't have `visionos` in the platform type API.
thii
force-pushed
the
t/fix-broken-builds-with-bazel-6.4.0
branch
from
99ea01b to
bb31fe2
Compare
|
Looks like we're only testing with 7 LTS and 6 LTS which doesn't cover 6.3.x and below. |
thii
requested review from
BalestraPatrick,
keith,
luispadron and
mattrobmattrob
as code owners
luispadron
approved these changes
Jan 24, 2024
|
ah yea I forgot we cherry picked this. i guess we could test an older 6.x, although also I think we assume that folks can safely and easily update to the newest of a LTS train so it's less of an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which doesn't have
visionosin the platform type API.