Skip to content

Commit

Permalink
Remove j2objc from rules_apple
Browse files Browse the repository at this point in the history
  • Loading branch information
erikkerber committed Oct 9, 2024
1 parent b4a1d1e commit c7b4962
Showing 1 changed file with 0 additions and 20 deletions.
20 changes: 0 additions & 20 deletions apple/internal/rule_attrs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -161,26 +161,6 @@ def _j2objc_binary_linking_attrs(*, deps_cfg):
cfg = deps_cfg,
default = Label("@bazel_tools//tools/objc:dummy_lib"),
),
"_j2objc_dead_code_pruner": attr.label(
executable = True,
# Setting `allow_single_file=True` would be more correct. Unfortunately,
# doing so prevents using py_binary as the underlying target because py_binary
# produces at least _two_ output files (the executable plus any files in srcs)
allow_files = True,
cfg = "exec",
default = Label("@bazel_tools//tools/objc:j2objc_dead_code_pruner_binary"),
),
# xcrunwrapper is no longer used by rules_apple, but the underlying implementation of
# apple_common.link_multi_arch_binary and j2objc_dead_code_pruner require this attribute.
# See CompilationSupport.java:
# - `registerJ2ObjcDeadCodeRemovalActions()`
# - `registerLinkActions()` --> `registerBinaryStripAction()`
# TODO(b/117932394): Remove this attribute once Bazel no longer uses xcrunwrapper.
"_xcrunwrapper": attr.label(
cfg = "exec",
executable = True,
default = Label("@bazel_tools//tools/objc:xcrunwrapper"),
),
}

def _static_library_linking_attrs(*, deps_cfg):
Expand Down

0 comments on commit c7b4962

Please sign in to comment.