Skip to content

Commit

Permalink
Update comment, test removing _dummy_lib
Browse files Browse the repository at this point in the history
  • Loading branch information
erikkerber committed Oct 9, 2024
1 parent 28dd1da commit c37a756
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions apple/internal/rule_attrs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,16 @@ def _j2objc_binary_linking_attrs(*, deps_cfg):
use the same transition.
"""
return {
"_dummy_lib": attr.label(
cfg = deps_cfg,
default = Label("@bazel_tools//tools/objc:dummy_lib"),
),
# "_dummy_lib": attr.label(
# cfg = deps_cfg,
# default = Label("@bazel_tools//tools/objc:dummy_lib"),
# ),
# xcrunwrapper is no longer used by rules_apple, but the underlying implementation of
# apple_common.link_multi_arch_binary and j2objc_dead_code_pruner require this attribute.
# See CompilationSupport.java:
# - `registerJ2ObjcDeadCodeRemovalActions()`
# - `registerLinkActions()` --> `registerBinaryStripAction()`
# TODO(b/117932394): Remove this attribute once Bazel no longer uses xcrunwrapper.
# TODO(b/117932394): Remove this once Bazel 6 support is dropped.
"_xcrunwrapper": attr.label(
cfg = "exec",
executable = True,
Expand Down

0 comments on commit c37a756

Please sign in to comment.