Skip to content

Commit

Permalink
Add manual tag to test bundle rule
Browse files Browse the repository at this point in the history
Fixes an issue related to toolchain selection when doing `//...` multi-platform builds.

Signed-off-by: Brentley Jones <[email protected]>
  • Loading branch information
brentleyjones committed Feb 19, 2025
1 parent be89110 commit bc24ec7
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions apple/internal/testing/apple_test_assembler.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,17 @@ def _assemble(name, bundle_rule, test_rule, runner = None, runners = None, **kwa
# `bundle_name` is either provided or the default is `name`.
bundle_name = bundle_attrs.pop("bundle_name", name)

# `//...` shouldn't try to build the bundle rule directly.
bundle_tags = bundle_attrs.pop("tags", [])
if "manual" not in bundle_tags:
bundle_tags = bundle_tags + ["manual"]

# Ideally this target should be private, but the outputs should not be private, so we're
# explicitly using the same visibility as the test (or None if none was set).
bundle_rule(
name = test_bundle_name,
bundle_name = bundle_name,
tags = bundle_tags,
test_bundle_output = "{}.zip".format(bundle_name),
testonly = True,
**bundle_attrs
Expand Down

0 comments on commit bc24ec7

Please sign in to comment.