even more

bazelbuild · Jan 22, 2024 · a9d5e83 · a9d5e83
1 parent ec3192e
commit a9d5e83
Show file tree

Hide file tree

Showing 5 changed files with 56 additions and 25 deletions.
diff --git a/apple/internal/ios_rules.bzl b/apple/internal/ios_rules.bzl
@@ -143,6 +143,9 @@ load("@build_bazel_rules_swift//swift:swift.bzl", "SwiftInfo")
 load("@bazel_skylib//lib:collections.bzl", "collections")
 load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")
 
+# TODO: Remove once we drop bazel 7.x
+_OBJC_PROVIDER_LINKING = hasattr(apple_common.new_objc_provider(), "linkopt")
+
 def _ios_application_impl(ctx):
     """Implementation of ios_application."""
     rule_descriptor = rule_support.rule_descriptor(
@@ -1607,10 +1610,7 @@ def _ios_dynamic_framework_impl(ctx):
                 feature_configuration = cc_features,
                 libraries = provider.framework_files.to_list(),
             )
-            additional_providers.extend([
-                apple_common.new_objc_provider(
-                    dynamic_framework_file = provider.framework_files,
-                ),
+            additional_providers.append(
                 CcInfo(
                     linking_context = cc_common.create_linking_context(
                         linker_inputs = depset([
@@ -1621,7 +1621,13 @@ def _ios_dynamic_framework_impl(ctx):
                         ]),
                     ),
                 ),
-            ])
+            )
+            if _OBJC_PROVIDER_LINKING:
+                additional_providers.append(
+                    apple_common.new_objc_provider(
+                        dynamic_framework_file = provider.framework_files,
+                    ),
+                )
     providers.extend(additional_providers)
 
     return [

diff --git a/apple/internal/macos_rules.bzl b/apple/internal/macos_rules.bzl
@@ -142,6 +142,9 @@ load(
 )
 load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")
 
+# TODO: Remove once we drop bazel 7.x
+_OBJC_PROVIDER_LINKING = hasattr(apple_common.new_objc_provider(), "linkopt")
+
 def _macos_application_impl(ctx):
     """Implementation of macos_application."""
     rule_descriptor = rule_support.rule_descriptor(
@@ -3194,10 +3197,7 @@ def _macos_dynamic_framework_impl(ctx):
                 feature_configuration = cc_features,
                 libraries = provider.framework_files.to_list(),
             )
-            additional_providers.extend([
-                apple_common.new_objc_provider(
-                    dynamic_framework_file = provider.framework_files,
-                ),
+            additional_providers.append(
                 CcInfo(
                     linking_context = cc_common.create_linking_context(
                         linker_inputs = depset([
@@ -3208,7 +3208,13 @@ def _macos_dynamic_framework_impl(ctx):
                         ]),
                     ),
                 ),
-            ])
+            )
+            if _OBJC_PROVIDER_LINKING:
+                additional_providers.append(
+                    apple_common.new_objc_provider(
+                        dynamic_framework_file = provider.framework_files,
+                    ),
+                )
     providers.extend(additional_providers)
 
     return [

diff --git a/apple/internal/partials/framework_provider.bzl b/apple/internal/partials/framework_provider.bzl
@@ -27,6 +27,9 @@ load(
     "framework_import_support",
 )
 
+# TODO: Remove once we drop bazel 7.x
+_OBJC_PROVIDER_LINKING = hasattr(apple_common.new_objc_provider(), "linkopt")
+
 def _framework_provider_partial_impl(
         *,
         actions,
@@ -62,10 +65,13 @@ def _framework_provider_partial_impl(
 
     # TODO(cparsons): These will no longer be necessary once apple_binary
     # uses the values in the dynamic framework provider.
-    legacy_objc_provider = apple_common.new_objc_provider(
-        dynamic_framework_file = depset([] if bundle_only else [framework_file]),
-        providers = [objc_provider],
-    )
+    if _OBJC_PROVIDER_LINKING:
+        legacy_objc_provider = apple_common.new_objc_provider(
+            dynamic_framework_file = depset([] if bundle_only else [framework_file]),
+            providers = [objc_provider],
+        )
+    else:
+        legacy_objc_provider = None
 
     library_to_link = cc_common.create_library_to_link(
         actions = actions,

diff --git a/apple/internal/tvos_rules.bzl b/apple/internal/tvos_rules.bzl
@@ -134,6 +134,9 @@ load(
 )
 load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")
 
+# TODO: Remove once we drop bazel 7.x
+_OBJC_PROVIDER_LINKING = hasattr(apple_common.new_objc_provider(), "linkopt")
+
 def _tvos_application_impl(ctx):
     """Experimental implementation of tvos_application."""
     rule_descriptor = rule_support.rule_descriptor(
@@ -698,10 +701,7 @@ def _tvos_dynamic_framework_impl(ctx):
                 feature_configuration = cc_features,
                 libraries = provider.framework_files.to_list(),
             )
-            additional_providers.extend([
-                apple_common.new_objc_provider(
-                    dynamic_framework_file = provider.framework_files,
-                ),
+            additional_providers.append(
                 CcInfo(
                     linking_context = cc_common.create_linking_context(
                         linker_inputs = depset([
@@ -712,7 +712,13 @@ def _tvos_dynamic_framework_impl(ctx):
                         ]),
                     ),
                 ),
-            ])
+            )
+            if _OBJC_PROVIDER_LINKING:
+                additional_providers.append(
+                    apple_common.new_objc_provider(
+                        dynamic_framework_file = provider.framework_files,
+                    ),
+                )
     providers.extend(additional_providers)
 
     return [
@@ -1244,8 +1250,9 @@ def _tvos_extension_impl(ctx):
                 processor_result.output_groups,
             )
         ),
-        apple_common.new_executable_binary_provider(
+        linking_support.new_executable_binary_provider(
             binary = binary_artifact,
+            cc_info = link_result.cc_info,
             objc = link_result.objc,
         ),
         new_tvosextensionbundleinfo(),

diff --git a/apple/internal/watchos_rules.bzl b/apple/internal/watchos_rules.bzl
@@ -137,6 +137,9 @@ load(
     "sets",
 )
 
+# TODO: Remove once we drop bazel 7.x
+_OBJC_PROVIDER_LINKING = hasattr(apple_common.new_objc_provider(), "linkopt")
+
 def _watchos_framework_impl(ctx):
     """Experimental implementation of watchos_framework."""
     rule_descriptor = rule_support.rule_descriptor(
@@ -651,10 +654,7 @@ def _watchos_dynamic_framework_impl(ctx):
                 feature_configuration = cc_features,
                 libraries = provider.framework_files.to_list(),
             )
-            additional_providers.extend([
-                apple_common.new_objc_provider(
-                    dynamic_framework_file = provider.framework_files,
-                ),
+            additional_providers.append(
                 CcInfo(
                     linking_context = cc_common.create_linking_context(
                         linker_inputs = depset([
@@ -665,7 +665,13 @@ def _watchos_dynamic_framework_impl(ctx):
                         ]),
                     ),
                 ),
-            ])
+            )
+            if _OBJC_PROVIDER_LINKING:
+                additional_providers.append(
+                    apple_common.new_objc_provider(
+                        dynamic_framework_file = provider.framework_files,
+                    ),
+                )
     providers.extend(additional_providers)
 
     return [