Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #1842

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @luispadron, modules you maintain (rules_ios) have been updated in this PR. Please review the changes.

luispadron
luispadron previously approved these changes Apr 18, 2024
bazel-io
bazel-io previously approved these changes Apr 18, 2024
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy meteorcloudy enabled auto-merge (squash) April 18, 2024 17:44
auto-merge was automatically disabled April 18, 2024 18:49

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed stale reviews from luispadron and themself April 18, 2024 18:50

Require module maintainers' approval for newly pushed changes.

@luispadron
Copy link
Contributor

Had to update presubmit to do something similar to: bazelbuild/rules_apple#2377

luispadron
luispadron previously approved these changes Apr 18, 2024
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Apr 18, 2024
@meteorcloudy meteorcloudy enabled auto-merge (squash) April 18, 2024 18:51
auto-merge was automatically disabled April 18, 2024 18:57

Head branch was pushed to by a user without write access

@bazel-io bazel-io dismissed luispadron’s stale review April 18, 2024 18:58

Require module maintainers' approval for newly pushed changes.

Copy link
Contributor

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok should be green now, had to split the behavior between 6 & 7. Upstreaming the changes here bazel-ios/rules_ios#868

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@brentleyjones brentleyjones merged commit e36ddf7 into bazelbuild:main Apr 18, 2024
10 checks passed
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants