Don't follow symlinks when hashing cache files (#10)

Fixes performance regression in 2eb83dc
bazel-contrib · Mar 13, 2024 · c033bc0 · c033bc0
1 parent 1cc0c15
commit c033bc0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/dist/post/index.js b/dist/post/index.js
@@ -95859,7 +95859,12 @@ async function saveCache(cacheConfig) {
   try {
     core.startGroup(`Save cache for ${cacheConfig.name}`)
     const paths = cacheConfig.paths
-    const hash = await glob.hashFiles(cacheConfig.files.join('\n'))
+    const hash = await glob.hashFiles(
+      cacheConfig.files.join('\n'),
+      undefined,
+      // We don't want to follow symlinks as it's extremely slow on macOS.
+      { followSymbolicLinks: false }
+    )
     const key = `${config.baseCacheKey}-${cacheConfig.name}-${hash}`
     console.log(`Attempting to save ${paths} cache to ${key}`)
     await cache.saveCache(paths, key)

diff --git a/dist/post/index.js.map b/dist/post/index.js.map
diff --git a/post.js b/post.js
@@ -72,7 +72,12 @@ async function saveCache(cacheConfig) {
   try {
     core.startGroup(`Save cache for ${cacheConfig.name}`)
     const paths = cacheConfig.paths
-    const hash = await glob.hashFiles(cacheConfig.files.join('\n'))
+    const hash = await glob.hashFiles(
+      cacheConfig.files.join('\n'),
+      undefined,
+      // We don't want to follow symlinks as it's extremely slow on macOS.
+      { followSymbolicLinks: false }
+    )
     const key = `${config.baseCacheKey}-${cacheConfig.name}-${hash}`
     console.log(`Attempting to save ${paths} cache to ${key}`)
     await cache.saveCache(paths, key)