Fix collection of Maven runtime deps #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures look unrelated |
fmeum
force-pushed
the
runtime-deps-fix
branch
from
df6071d to
4708c77
Compare
A transitive dependency of a `maven_project_jar` is a runtime dependency if and only if each path to it from the root goes through at least one `runtime_deps` edge. Before this commit, every transitive dependency that was reachable from the root via at least one path with a `runtime_deps` edge was considered to be a runtime dependency, even if other paths require it as a compile dependency. Also show a helpful error when users attempt to move a dep from `runtime_deps` to `deps` on a `java_export` target with no `srcs`.
fmeum
force-pushed
the
runtime-deps-fix
branch
from
4708c77 to
94d599e
Compare
|
I didn't notice that some CI failures were related to this PR. They are now fixed. I also temporarily patched the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A transitive dependency of a
maven_project_jaris a runtime dependency if and only if each path to it from the root goes through at least oneruntime_depsedge. Before this commit, every transitive dependency that was reachable from the root via at least one path with aruntime_depsedge was considered to be a runtime dependency, even if other paths require it as a compile dependency. This fixes a regression introduced by 7b0abdc.Also show a helpful error when users attempt to move a dep from
runtime_depstodepson ajava_exporttarget with nosrcs.Work towards CodeIntelligenceTesting/jazzer#919