-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hermetic ctk with deliverable #285
Open
cloudhan
wants to merge
7
commits into
cloudhan/hermetic-breaking-changes
Choose a base branch
from
cloudhan/hermetic-ctk-2
base: cloudhan/hermetic-breaking-changes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: hermetic ctk with deliverable #285
cloudhan
wants to merge
7
commits into
cloudhan/hermetic-breaking-changes
from
cloudhan/hermetic-ctk-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ced2e2
to
35d3cbd
Compare
2660487
to
49aaa29
Compare
44c74a6
to
b886a49
Compare
49aaa29
to
9fd0d83
Compare
255a4df
to
31495ea
Compare
f922cb1
to
06bbedf
Compare
daeceb6
to
9506e4c
Compare
5491ada
to
81b26d3
Compare
Also stop using `Label(...)` in local_cuda as the dev experience is really awful when components_mapping fallbacks to `attr.string_dict`
eafca8d
to
9106b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #283
This adds a new repo rule
cuda_component
and existing repo rule is adapt respectively.We organize the generated repo as follows, for both
local_cuda
andlocal_cuda_<component_repo_name>
If the repo is
local_cuda
, we additionally generate toolchain config as followsHow are component repositories and
@local_cuda
connected?The
registry.bzl
file holds mappings from our (rules_cuda
) components name to various things.The registry serve the following purpose:
maps our component names to full component names used
redistrib.json
file.This is purely for looking up the json files.
maps our component names to target names to be exposed under
@local_cuda
repo.To expose those targets, we use a
components_mapping
attr from our component names to labels of component repository (for example,@local_cuda_nvcc
) as followsThis basically means the component
cudart
hascuda
,cuda_runtime
andcuda_runtime_static
targets defined.@local_cuda
directly.@local_cuda_cudart_v12.6.77
repo. And alias all targets to@local_cuda
as followscuda_component
is in charge of setting up the repo@local_cuda_cudart_v12.6.77
.