Fix hang when processing additional stats

Signed-off-by: Maxime Gervais <[email protected]>
bavc · Dec 23, 2024 · a711073 · a711073
1 parent 80ed24f
commit a711073
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/Source/Core/CommonStats.cpp b/Source/Core/CommonStats.cpp
@@ -263,9 +263,6 @@ void CommonStats::writeAdditionalStats(std::stringstream &stream, size_t index)
 
 void CommonStats::updateAdditionalStats(StatsValueInfo::Type type, size_t oldSize, size_t size)
 {
-    // Lock data
-    QMutexLocker Lock(&Mutex);
-
     if (type==StatsValueInfo::Int)
     {
         auto additionalIntStats_Old = additionalIntStats;

diff --git a/Source/Core/CommonStats.h b/Source/Core/CommonStats.h
@@ -166,7 +166,6 @@ class CommonStats
     typedef std::string StringStatsKey;
 
     void initializeAdditionalStats();
-    void updateAdditionalStats(StatsValueInfo::Type type, size_t oldSize, size_t size);
     void processAdditionalStats(const char* key, const char* value, bool statsMapInitialized);
     void writeAdditionalStats(std::stringstream& stream, size_t index);
 
@@ -200,8 +199,11 @@ class CommonStats
     double**                    additionalDoubleStats;
     char***                     additionalStringStats;
 
-   // Thread synchronisation
-   QMutex                       Mutex;
+    // Thread synchronisation
+    QMutex                       Mutex;
+
+    // Internal functions
+    void updateAdditionalStats(StatsValueInfo::Type type, size_t oldSize, size_t size);
 };
 
 #endif // Stats_H