Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrimmage Rate Limiting #918

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Scrimmage Rate Limiting #918

merged 4 commits into from
Jan 23, 2025

Conversation

lowtorola
Copy link
Contributor

  • adds rate limit field to episode for easy admin interface tuning (could be a django setting if ppl prefer but i like it here)
  • descriptively errors with 429 too many requests if the user requests too many scrims

what do you think the rate limit should be @nour-massri or @TheApplePieGod ? I'm gonna say 20 seems like a very reasonable number :)

lowtorola
lowtorola commented Jan 23, 2025
View reviewed changes
Copy link
Contributor Author

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@lowtorola lowtorola merged commit 4eada47 into main Jan 23, 2025
3 checks passed
@lowtorola lowtorola deleted the rate-limit-scrimmages branch January 23, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheApplePieGod TheApplePieGod Awaiting requested review from TheApplePieGod

@nour-massri nour-massri Awaiting requested review from nour-massri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lowtorola