add sentinel multi monitor #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need to declare a master.
modulesync 4.0.0
The path when using an SCL is non-standard. Using the correct one prevents permission issues.
CentOS 6 is EOL and we can't test RHEL 6. That means there's no guarantee it continues to work. Also, all other distros mentioned in metadata.json run systemd. This allows the module to be cleaned up. For the sentinel, every supported distro provides a systemd unit file as part of the package. On Debian, it also provides a sysvinit file. Including this in the module is not needed. In most cases, the systemd unit file would have already shadowed the sysvinit file.
These default to true and by now we can rely on them to be present. The systemd unit files all have them so there's really no reason to keep this around.
This removes the use of file defaults and moves all variables used in the template together.
Drop sysinit support
Add support for rename-command in redis.conf
Remove support for THP in Redis module - recommend forge module
Set the correct log dir on RH SCL
0c851ce changed $log_dir for SCL deployments. However, $log_file was still absolute. That caused it to log to a non-existing directory. This patch makes $log_file accept a relative path. If a relative path is specified, $log_dir will be prepended. Absolute paths are still used directly which keeps API compatibility.
Allow relative paths for $log_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
After multi instance was added we should let redis-sentinel watch over these instances
This Pull Request (PR) add following features and fixes the following issues