TQLG-416: create a visibility mechanism #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnansaadeddine
requested review from
aheartforspinach,
m-borgmann,
mloeffle and
jkniest
as code owners
# Conflicts: # components/Cms/CmsPage.vue # components/Cms/Element/CmsElementImageSlider.vue # components/Product/ProductCard.vue # components/ProductListing/ProductListingSidebar.vue
aheartforspinach
approved these changes
Mar 4, 2025
Co-authored-by: nele sophie <[email protected]>
m-borgmann
reviewed
Mar 6, 2025
Comment on lines
+113
to
+114
| </ClientOnly> | ||
| <div class="flex overflow-hidden" :class="placeholderClasses"> |
There was a problem hiding this comment.
Suggested change
| </ClientOnly> | |
| <div class="flex overflow-hidden" :class="placeholderClasses"> | |
| </ClientOnly> | |
| <div class="flex overflow-hidden" :class="placeholderClasses"> |
m-borgmann
reviewed
Mar 6, 2025
| } | ||
|
|
||
| if (!elementConfig.lazyLoad.length) { | ||
| cb(); |
There was a problem hiding this comment.
I think it would be better to rename this to callback
m-borgmann
reviewed
Mar 6, 2025
| watchElementLoaded(element, () => { | ||
| config.loaded = true; | ||
|
|
||
| cb(); |
There was a problem hiding this comment.
I think it would be better to rename this to callback
m-borgmann
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.