Make the LazyVIM extras more modular based on the installed dev language #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tonysm
force-pushed
the
tm/lazyvim-extras-modular
branch
from
c94820f to
46859d8
Compare
dhh
reviewed
Feb 4, 2025
| jq_extras="[${jq_extras%,}]" | ||
|
|
||
| jq --argjson extras "$jq_extras" '.extras |= (. + $extras | unique)' ~/.config/nvim/lazyvim.json >"$temp_file" && | ||
| mv "$temp_file" ~/.config/nvim/lazyvim.json |
There was a problem hiding this comment.
Rather than the temp file dance, I would just touch ~/.config/nvim/lazyvim.json first, then assume it's there.
There was a problem hiding this comment.
The temp file is used because we can't read and write to the same file in a pipeline, something to do with it using the same file descriptor. I tried here without the temp file, and the config file ended up empty.
However, I found some tricks to achieve this behavior, as described here. I've updated the code to use one of the tricks described there and it looks like it works.
There was a problem hiding this comment.
(happy to revert it to use a tmp file, if you don't want to use this trick, btw)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
lazyvim.jsonI started this work at #156 but it was mixed with changing PHP's default LSP on LazyVIM. I'll send a separate PR for that.