Removed max retries from OpenAI streaming chat model (helidon-io#9767)

barchetta · Feb 11, 2025 · cf9acb4 · cf9acb4
1 parent ffb25fd
commit cf9acb4
Show file tree

Hide file tree

Showing 6 changed files with 43 additions and 10 deletions.
diff --git a/.../io/helidon/integrations/langchain4j/providers/openai/OpenAiChatModelConfigBlueprint.java b/.../io/helidon/integrations/langchain4j/providers/openai/OpenAiChatModelConfigBlueprint.java
@@ -39,6 +39,14 @@ interface OpenAiChatModelConfigBlueprint extends OpenAiCommonConfig {
      */
     String CONFIG_ROOT = "langchain4j.open-ai.chat-model";
 
+    /**
+     * The maximum number of retries for failed API requests.
+     *
+     * @return an {@link java.util.Optional} containing the maximum number of retries
+     */
+    @Option.Configured
+    Optional<Integer> maxRetries();
+
     /**
      * The sampling temperature to use, between 0 and 2.
      * Higher values make the output more random, while lower values make it

diff --git a/...rc/main/java/io/helidon/integrations/langchain4j/providers/openai/OpenAiCommonConfig.java b/...rc/main/java/io/helidon/integrations/langchain4j/providers/openai/OpenAiCommonConfig.java
@@ -81,14 +81,6 @@ interface OpenAiCommonConfig {
     @Option.Configured
     Optional<Duration> timeout();
 
-    /**
-     * The maximum number of retries for failed API requests.
-     *
-     * @return an {@link java.util.Optional} containing the maximum number of retries
-     */
-    @Option.Configured
-    Optional<Integer> maxRetries();
-
     /**
      * Proxy to use.
      *

diff --git a/...elidon/integrations/langchain4j/providers/openai/OpenAiEmbeddingModelConfigBlueprint.java b/...elidon/integrations/langchain4j/providers/openai/OpenAiEmbeddingModelConfigBlueprint.java
@@ -37,6 +37,14 @@ interface OpenAiEmbeddingModelConfigBlueprint extends OpenAiCommonConfig {
      */
     String CONFIG_ROOT = "langchain4j.open-ai.embedding-model";
 
+    /**
+     * The maximum number of retries for failed API requests.
+     *
+     * @return an {@link java.util.Optional} containing the maximum number of retries
+     */
+    @Option.Configured
+    Optional<Integer> maxRetries();
+
     /**
      * The dimensionality of the embeddings generated by the model.
      *

diff --git a/...io/helidon/integrations/langchain4j/providers/openai/OpenAiImageModelConfigBlueprint.java b/...io/helidon/integrations/langchain4j/providers/openai/OpenAiImageModelConfigBlueprint.java
@@ -36,6 +36,14 @@ interface OpenAiImageModelConfigBlueprint extends OpenAiCommonConfig {
      */
     String CONFIG_ROOT = "langchain4j.open-ai.image-model";
 
+    /**
+     * The maximum number of retries for failed API requests.
+     *
+     * @return an {@link java.util.Optional} containing the maximum number of retries
+     */
+    @Option.Configured
+    Optional<Integer> maxRetries();
+
     /**
      * The desired size of the generated images.
      *

diff --git a/...helidon/integrations/langchain4j/providers/openai/OpenAiLanguageModelConfigBlueprint.java b/...helidon/integrations/langchain4j/providers/openai/OpenAiLanguageModelConfigBlueprint.java
@@ -37,6 +37,14 @@ interface OpenAiLanguageModelConfigBlueprint extends OpenAiCommonConfig {
      */
     String CONFIG_ROOT = "langchain4j.open-ai.language-model";
 
+    /**
+     * The maximum number of retries for failed API requests.
+     *
+     * @return an {@link java.util.Optional} containing the maximum number of retries
+     */
+    @Option.Configured
+    Optional<Integer> maxRetries();
+
     /**
      * The sampling temperature to use, between 0 and 2.
      * Higher values make the output more random, while lower values make it

diff --git a/...lidon/integrations/langchain4j/providers/openai/OpenAiModerationModelConfigBlueprint.java b/...lidon/integrations/langchain4j/providers/openai/OpenAiModerationModelConfigBlueprint.java
@@ -16,6 +16,9 @@
 
 package io.helidon.integrations.langchain4j.providers.openai;
 
+import java.util.Optional;
+
+import io.helidon.builder.api.Option;
 import io.helidon.builder.api.Prototype;
 
 /**
@@ -26,11 +29,17 @@
  */
 @Prototype.Configured(OpenAiLanguageModelConfigBlueprint.CONFIG_ROOT)
 @Prototype.Blueprint
-// we want to have an explicit type for configuration, even if it does not add methods
-@SuppressWarnings("checkstyle:InterfaceIsType")
 interface OpenAiModerationModelConfigBlueprint extends OpenAiCommonConfig {
     /**
      * Default configuration prefix.
      */
     String CONFIG_ROOT = "langchain4j.open-ai.moderation-model";
+
+    /**
+     * The maximum number of retries for failed API requests.
+     *
+     * @return an {@link java.util.Optional} containing the maximum number of retries
+     */
+    @Option.Configured
+    Optional<Integer> maxRetries();
 }