Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(native list): disc version and ordered list marker left aligned #1589

Merged
merged 2 commits into from
Jan 31, 2025
Merged

✨ feat(native list): disc version and ordered list marker left aligned #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c2bb27
Create PR for #1584
github-actions[bot] Jan 30, 2025
c1356b2
feat(styles): add is-inside class to center align lists
hirsch88 Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-books-reply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': minor
---

**styles**: add `is-inside` class to lists (ul & ol) to center alignt the element
64 changes: 64 additions & 0 deletions packages/core/src/components/bal-list/test/bal-list.native.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,30 @@ <h2 class="title text-xx-large">Basic</h2>
<li>Item 4</li>
</ul>
</section>
<section class="text-align-center">
<ul class="list is-inside">
<li>Item 1</li>
<li>Item 2</li>
<li>Item 3</li>
<li>Item 4</li>
</ul>
</section>
<section>
<ol class="list">
<li>Item 1</li>
<li>Item 2</li>
<li>Item 3</li>
<li>Item 4</li>
</ol>
</section>
<section class="text-align-center">
<ol class="list is-inside">
<li>Item 1</li>
<li>Item 2</li>
<li>Item 3</li>
<li>Item 4</li>
</ol>
</section>
<h2 class="title text-xx-large">Bullet Circle</h2>
<section>
<ul class="list has-bullet-circle">
Expand All @@ -30,6 +54,14 @@ <h2 class="title text-xx-large">Bullet Circle</h2>
<li>Item 4</li>
</ul>
</section>
<section class="text-align-center">
<ul class="list has-bullet-circle is-inside">
<li>Item 1</li>
<li>Item 2</li>
<li>Item 3</li>
<li>Item 4</li>
</ul>
</section>
<h2 class="title text-xx-large">Bullet Check</h2>
<section>
<ul class="list has-bullet-check">
Expand All @@ -39,6 +71,14 @@ <h2 class="title text-xx-large">Bullet Check</h2>
<li>Item 4</li>
</ul>
</section>
<section class="text-align-center">
<ul class="list has-bullet-check is-inside">
<li>Item 1</li>
<li>Item 2</li>
<li>Item 3</li>
<li>Item 4</li>
</ul>
</section>
<h2 class="title text-xx-large">Bullet Check Circle</h2>
<section>
<ul class="list has-bullet-check-circle">
Expand All @@ -48,6 +88,14 @@ <h2 class="title text-xx-large">Bullet Check Circle</h2>
<li>Item 4</li>
</ul>
</section>
<section class="text-align-center">
<ul class="list has-bullet-check-circle is-inside">
<li>Item 1</li>
<li>Item 2</li>
<li>Item 3</li>
<li>Item 4</li>
</ul>
</section>
<h2 class="title text-xx-large">Bullet Close</h2>
<section>
<ul class="list has-bullet-close">
Expand All @@ -57,6 +105,14 @@ <h2 class="title text-xx-large">Bullet Close</h2>
<li>Item 4</li>
</ul>
</section>
<section class="text-align-center">
<ul class="list has-bullet-close is-inside">
<li>Item 1</li>
<li>Item 2</li>
<li>Item 3</li>
<li>Item 4</li>
</ul>
</section>
<h2 class="title text-xx-large">Bullet Arrow Down</h2>
<section>
<ul class="list has-bullet-arrow-down">
Expand All @@ -66,6 +122,14 @@ <h2 class="title text-xx-large">Bullet Arrow Down</h2>
<li>Item 4</li>
</ul>
</section>
<section class="text-align-center">
<ul class="list has-bullet-arrow-down is-inside">
<li>Item 1</li>
<li>Item 2</li>
<li>Item 3</li>
<li>Item 4</li>
</ul>
</section>
</main>
</bal-doc-app>
</body>
Expand Down
5 changes: 5 additions & 0 deletions packages/css/src/core/list.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ ul.is-list
margin-left: 2rem
+desktop
margin-bottom: 2rem
&.is-inside
list-style-position: inside !important
margin-left: 0
li
list-style-position: inside !important
li
hyphens: auto
margin-bottom: 1rem
Expand Down
5 changes: 5 additions & 0 deletions packages/styles/src/core/list.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ ul.is-list
margin-left: 2rem
+desktop
margin-bottom: 2rem
&.is-inside
list-style-position: inside !important
margin-left: 0
li
list-style-position: inside !important
li
hyphens: auto
margin-bottom: 1rem
Expand Down