Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ballerina to OAS] HATEOAS Support #1589

Merged
merged 117 commits into from
Jan 31, 2024
Merged

[Ballerina to OAS] HATEOAS Support #1589

merged 117 commits into from
Jan 31, 2024

Conversation

SachinAkash01
Copy link
Member

Purpose

$subject

Fixes: #5098
See Also: #5087

lnash94 and others added 20 commits December 18, 2023 14:00
@lnash94
Resolve conflicts
7d6dfca
@SachinAkash01
Initial commit
0a94431
@SachinAkash01
Fix checkstyle errors
1e4b3e2
@SachinAkash01
Fix checkstyle errors
804da50
@ayeshLK
Fix checkstyle violations
e0403dc
@ayeshLK
Implement hateoas meta-info sharing logic
5a48390
@SachinAkash01
Merge branch 'hypermedia_support' into bal-hateoas-to-oas
df44930
@SachinAkash01
Merge pull request #3 from ayeshLK/bal-hateoas-to-oas
682aa67 
Implement hateoas meta-info sharing logic
@ayeshLK
Remove unwanted node-visitor
e06bebb
@ayeshLK
Update node-visiting logic to extract hateoas-metadata
7f0688f
@ayeshLK
Update shared hateoas metadata updating logic
80cb406
@ayeshLK
Mark hateoas resource as a record
95b4d66
@ayeshLK
Refactor common utility functions and their usage
f3a2fb5
@ayeshLK
Fix checkstyle violations
527b921
@ayeshLK
Resolve merge conflicts
f22e634
@SachinAkash01
Merge pull request #4 from ayeshLK/bal-hateoas-to-oas
8e30086 
Update shared HATEOAS metadata updating logic
@SachinAkash01
Add hateoas mapper
96d2951
@SachinAkash01
Implementing hateoas link object
fbedc37
@SachinAkash01
Fix checkstyle violations
a3a826d
@SachinAkash01
Improve hateoas mapper
4dca3fe
@SachinAkash01 SachinAkash01 force-pushed the hypermedia_support branch 2 times, most recently from c7866ba to 4dca3fe Compare January 5, 2024 08:16
TharmiganK
TharmiganK reviewed Jan 22, 2024
View reviewed changes
ballerina-to-openapi/src/main/java/io/ballerina/openapi/service/mapper/ResourceMapper.java Outdated Show resolved Hide resolved
...ina-to-openapi/src/main/java/io/ballerina/openapi/service/mapper/ServiceToOpenAPIMapper.java Outdated Show resolved Hide resolved
...-to-openapi/src/main/java/io/ballerina/openapi/service/mapper/hateoas/HateoasMapperImpl.java Outdated Show resolved Hide resolved
...-to-openapi/src/main/java/io/ballerina/openapi/service/mapper/hateoas/HateoasMapperImpl.java Outdated Show resolved Hide resolved
...-to-openapi/src/main/java/io/ballerina/openapi/service/mapper/hateoas/HateoasMapperImpl.java Show resolved Hide resolved
...penapi/src/main/java/io/ballerina/openapi/service/mapper/hateoas/HateoasMetadataVisitor.java Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: 314 lines in your changes are missing coverage. Please review.

Comparison is base (493cc64) 79.62% compared to head (e75d546) 80.00%.
Report is 109 commits behind head on bal-hateos-to-oas.

Files Patch % Lines
...ervice/mapper/constraint/ConstraintMapperImpl.java 80.88% 32 Missing and 11 partials ⚠️
...pi/service/mapper/response/ResponseMapperImpl.java 84.91% 22 Missing and 21 partials ⚠️
...ina/openapi/service/mapper/ResourceMapperImpl.java 82.75% 11 Missing and 9 partials ⚠️
.../openapi/service/mapper/type/RecordTypeMapper.java 81.00% 9 Missing and 10 partials ⚠️
...a/openapi/service/mapper/type/UnionTypeMapper.java 75.36% 9 Missing and 8 partials ⚠️
...o/ballerina/openapi/service/mapper/InfoMapper.java 11.76% 15 Missing ⚠️
.../service/mapper/parameter/ParameterMapperImpl.java 83.69% 7 Missing and 8 partials ⚠️
...ervice/mapper/parameter/HeaderParameterMapper.java 83.52% 3 Missing and 11 partials ⚠️
...openapi/service/mapper/ServiceToOpenAPIMapper.java 89.32% 7 Missing and 4 partials ⚠️
.../openapi/service/mapper/type/SimpleTypeMapper.java 58.33% 8 Missing and 2 partials ⚠️
... and 23 more
Additional details and impacted files 
@@                   Coverage Diff                   @@
##             bal-hateos-to-oas    #1589      +/-   ##
=======================================================
+ Coverage                79.62%   80.00%   +0.37%     
- Complexity                1815     1894      +79     
=======================================================
  Files                      142      149       +7     
  Lines                     9797     9983     +186     
  Branches                  1603     1631      +28     
=======================================================
+ Hits                      7801     7987     +186     
+ Misses                    1427     1417      -10     
- Partials                   569      579      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SachinAkash01 SachinAkash01 mentioned this pull request Jan 26, 2024
Closed
@SachinAkash01 @lnash94
Update license header
e78ea81 
Co-authored-by: Sumudu Nissanka <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ayeshLK ayeshLK merged commit 7036cfb into ballerina-platform:bal-hateos-to-oas Jan 31, 2024
6 checks passed
@lnash94 lnash94 mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe left review comments

@TharmiganK TharmiganK TharmiganK left review comments

@ayeshLK ayeshLK ayeshLK left review comments

@lnash94 lnash94 lnash94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SachinAkash01 @lnash94 @NipunaRanasinghe @TharmiganK @ayeshLK