Use direct coping of CSV file due to config map limits #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K8s config maps can only holds up to 1MB. So, we have to use direct copying to container instead of using a config map.
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
=========================================
Coverage 80.41% 80.41%
Complexity 14 14
=========================================
Files 58 58
Lines 2058 2058
Branches 549 549
=========================================
Hits 1655 1655
Misses 313 313
Partials 90 90 Continue to review full report at Codecov.
|
daneshk
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
K8s config maps can only hold up to 1MB. So, we have to use direct copying to the container instead of using a config map.
Related to - ballerina-platform/ballerina-performance-cloud#3178
Examples
Checklist