Add enum and finite type support for 1.0.x #58
Conversation
|
I verified the fix implemented in this PR by testing it locally, and it resolved the issue as expected. |
ballerina/Ballerina.toml
Outdated
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| org = "ballerina" | |||
| name = "data.xmldata" | |||
| version = "1.0.0" | |||
| version = "1.0.1" | |||
There was a problem hiding this comment.
I think this should be a minor, since the runtime behaviour changes (despite it being a bug previously).
There was a problem hiding this comment.
The runtime behaviour only changes for the Finite types ryt?
And also its a error become a valid output.
So no breaking change.
Isnt is better to release a patch?
And also the next minor version will be pack with U11
There was a problem hiding this comment.
If someone tested the result to see if it is error, what previously returned true now returns false (or vice versa). While it is an edge case and relies on a bug, it can still be considered breaking.
There was a problem hiding this comment.
Fixed in e2ffd01
Implement the support for enums and singleton support.
Fixes: ballerina-platform/ballerina-library#7355