Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraint validation #21

Merged
merged 12 commits into from
Jul 31, 2024
+711 −29
Merged

Add constraint validation #21

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5c20bb2
Add constraint annotation validation
prakanth97 May 29, 2024
1e4f000
Add constraint validation tests
prakanth97 May 29, 2024
837e389
[Automated] Update the native jar versions
prakanth97 May 29, 2024
457e065
Add module ballerina time as dependency
prakanth97 May 29, 2024
27a0dfa
Resolve merge conflicts
prakanth97 Jun 6, 2024
2aae455
Address review suggestions
prakanth97 Jun 14, 2024
28d40fa
Resolve merge conflict
prakanth97 Jun 14, 2024
f254072
Resolve merge conflicts
prakanth97 Jul 22, 2024
0bbdaa6
Add tests for disabling constraint validation
prakanth97 Jul 22, 2024
1990aeb
Resolve merge conflicts
prakanth97 Jul 25, 2024
2f4694a
Sync with main
prakanth97 Jul 25, 2024
a348f15
Resolve merge conflicts
prakanth97 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for disabling constraint validation
@prakanth97
prakanth97 committed Jul 22, 2024
commit 0bbdaa6abae99ebea2102107811d1ad707bc051e
150 changes: 139 additions & 11 deletions ballerina/tests/constraint_annotation_test.bal
View file
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ public type ValidationPerson record {|
option: {
value: "PAST",
message: "Date of birth should be past value"
},
},
message: "Invalid date found for date of birth"
}
time:Date dob;
@@ -87,9 +87,9 @@ function testValidConstraintAnnotationForParseString() returns error? {
test:assertEquals(person.dob.month, 12);
test:assertEquals(person.dob.day, 31);
test:assertEquals(person.family.id, 2221);
test:assertEquals(person.family.members.length(), 2);
test:assertEquals(person.family.members[0], "John");
test:assertEquals(person.family.members[1], "Doe");
test:assertEquals(person.family.members.length(), 2);
test:assertEquals(person.family.members[0], "John");
test:assertEquals(person.family.members[1], "Doe");
}

@constraint:Array {
@@ -108,7 +108,7 @@ public type ValidationItem record {|
function testInvalidConstraintAnnotationForParseString(string sourceData, typedesc<record {}> expType, string expectedError) {
anydata|Error err = parseString(sourceData, {}, expType);
test:assertEquals(err is Error, true);
test:assertEquals((<error> err).message(), expectedError);
test:assertEquals((<error>err).message(), expectedError);
}

function invalidConstraintAnnotation() returns [string, typedesc<record {}>, string][] {
@@ -196,7 +196,7 @@ function invalidConstraintAnnotation() returns [string, typedesc<record {}>, str
`,
ValidationPerson,
"Validation failed for '$.height:maxFractionDigits' constraint(s)."
],
],
[
string `
<Person>
@@ -254,6 +254,70 @@ function invalidConstraintAnnotation() returns [string, typedesc<record {}>, str
];
}

@test:Config {
groups: ["constraint-validation"],
dataProvider: disableConstraintValidation
}
function testDisableConstraintValidationForParseString(string sourceData, typedesc<record {}> expType, anydata result) returns error? {
anydata err = check parseString(sourceData, {enableConstraintValidation: false}, expType);
test:assertEquals(err, result);
}

function disableConstraintValidation() returns [string, typedesc<record {}>, anydata][] {
return [
[
string `
<Person>
<name>John Doe</name>
<age>4</age>
<height>185.215</height>
<dob>
<year>5000</year>
<month>12</month>
<day>31</day>
</dob>
<family>
<id>22213</id>
<members>John</members>
<members>Doe</members>
<members>Ross</members>
</family>
</Person>
`,
ValidationPerson,
{
"name": "John Doe",
"age": 4,
"height": 185.215,
"dob": {
"year": 5000,
"month": 12,
"day": 31
},
"family": {
"id": 22213,
"members": [
"John",
"Doe",
"Ross"
]
}
}
],
[
string `
<Item>
<weight>1.2</weight>
<weight>2.3</weight>
<weight>3.4</weight>
</Item>
`,
ValidationItem,
<ValidationItem> {"weight": [1.2, 2.3, 3.4]}
]
];
}

@test:Config {
groups: ["constraint-validation"]
}
@@ -283,9 +347,9 @@ function testValidConstraintAnnotationForParseAsType() returns error? {
test:assertEquals(person.dob.year, 1990);
test:assertEquals(person.dob.month, 12);
test:assertEquals(person.dob.day, 31);
test:assertEquals(person.family.members.length(), 2);
test:assertEquals(person.family.members[0], "John");
test:assertEquals(person.family.members[1], "Doe");
test:assertEquals(person.family.members.length(), 2);
test:assertEquals(person.family.members[0], "John");
test:assertEquals(person.family.members[1], "Doe");
}

@test:Config {
@@ -295,7 +359,7 @@ function testValidConstraintAnnotationForParseAsType() returns error? {
function testInvalidConstraintAnnotationForParseAsType(xml sourceData, typedesc<record {}> expType, string expectedError) {
anydata|Error err = parseAsType(sourceData, {}, expType);
test:assertEquals(err is Error, true);
test:assertEquals((<error> err).message(), expectedError);
test:assertEquals((<error>err).message(), expectedError);
}

function invalidConstraintAnnotationForParseAsType() returns [xml, typedesc<record {}>, string][] {
@@ -383,7 +447,7 @@ function invalidConstraintAnnotationForParseAsType() returns [xml, typedesc<reco
`,
ValidationPerson,
"Validation failed for '$.height:maxFractionDigits' constraint(s)."
],
],
[
xml `
<Person>
@@ -440,3 +504,67 @@ function invalidConstraintAnnotationForParseAsType() returns [xml, typedesc<reco
]
];
}

@test:Config {
groups: ["constraint-validation"],
dataProvider: disableConstraintValidationForParseAsType
}
function testDisableConstraintValidationForParseAsType(xml sourceData, typedesc<record {}> expType, anydata result) returns error? {
anydata err = check parseAsType(sourceData, {enableConstraintValidation: false}, expType);
test:assertEquals(err, result);
}

function disableConstraintValidationForParseAsType() returns [xml, typedesc<record {}>, anydata][] {
return [
[
xml `
<Person>
<name>John Doe</name>
<age>4</age>
<height>185.215</height>
<dob>
<year>5000</year>
<month>12</month>
<day>31</day>
</dob>
<family>
<id>22213</id>
<members>John</members>
<members>Doe</members>
<members>Ross</members>
</family>
</Person>
`,
ValidationPerson,
{
"name": "John Doe",
"age": 4,
"height": 185.215,
"dob": {
"year": 5000,
"month": 12,
"day": 31
},
"family": {
"id": 22213,
"members": [
"John",
"Doe",
"Ross"
]
}
}
],
[
xml `
<Item>
<weight>1.2</weight>
<weight>2.3</weight>
<weight>3.4</weight>
</Item>
`,
ValidationItem,
<ValidationItem> {"weight": [1.2, 2.3, 3.4]}
]
];
}