-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prettify API and Improve Build Scripts #7
Conversation
@ThisaruGuruge there is a conflict. |
Fixed now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
============================================
+ Coverage 76.80% 77.54% +0.73%
- Complexity 235 286 +51
============================================
Files 18 24 +6
Lines 1453 1692 +239
Branches 272 338 +66
============================================
+ Hits 1116 1312 +196
- Misses 235 256 +21
- Partials 102 124 +22 ☔ View full report in Codecov by Sentry. |
@ThisaruGuruge you have added |
Even though they are test-only dependencies, we need them to be built after the io, os, and file modules since we create an intermediate pack for testing. The dependency graph resolver will be resolving these accordingly. When adding to the distribution, let's add it under level 4. |
string result = string `${initialIndentation}{`; | ||
boolean isEmptyMap = value.keys().length() == 0; | ||
if !isEmptyMap { | ||
result += "\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding \n
to the string may cause failures in windows, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows tests are passing in the PR build. Is there a recommended way to handle this?
Purpose
Fixes: #6286
Fixes: https://github.com/wso2-enterprise/internal-support-ballerina/issues/632
Examples
N/A
Checklist
Updated the changelogUpdated the spec