Support union type #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakanth97
commented
May 3, 2024
native/src/main/java/io/ballerina/lib/data/jsondata/json/JsonParser.java
Outdated
Show resolved
Hide resolved
prakanth97
commented
May 3, 2024
native/src/main/java/io/ballerina/lib/data/jsondata/json/JsonParser.java
Outdated
Show resolved
Hide resolved
prakanth97
commented
May 3, 2024
native/src/main/java/io/ballerina/lib/data/jsondata/json/JsonParser.java
Outdated
Show resolved
Hide resolved
|
Shall we add a test with never and error |
Since both of these are not a subtype of anydata, we will get compile-time error. |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
SasinduDilshara
previously approved these changes
Jun 13, 2024
|
Shall we add tests with a scenario that, union type as a expected type and it match not with source |
|
Shall we add a test with union of singleton types |
Already we have test for that https://github.com/ballerina-platform/module-ballerina-data.jsondata/blob/main/ballerina/tests/from_json_string_test.bal#L1051 |
SasinduDilshara
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: #6261
Examples
Checklist